SLIDE 1
A DVCS pull request approach to personal feedback
Pull Request Feedback
ludwig@schubert.io
Pull Request Feedback A DVCS pull request approach to personal - - PowerPoint PPT Presentation
Pull Request Feedback A DVCS pull request approach to personal - - PowerPoint PPT Presentation
Pull Request Feedback A DVCS pull request approach to personal feedback ludwig@schubert.io duh. 3 1 2 4 5 How does the issue manifest? What is your interpretation? How would you suggest to fix it? Explain the reasoning of your fix. Show
SLIDE 2
SLIDE 3
SLIDE 4
SLIDE 5
SLIDE 6
duh.
SLIDE 7
SLIDE 8
1 2 3 4 5
SLIDE 9
How does the issue manifest? What is your interpretation? How would you suggest to fix it? Explain the reasoning of your fix. Show you made it easy to apply.
SLIDE 10
SLIDE 11
A DVCS pull request approach to personal feedback
Pull Request Feedback
ludwig@schubert.io
tiny.cc/pr-feedback
Personal feedback based on the open source pull request culturePull Request Feedback
How does the issue manifest?
Think about what exactly doesn’t work the way you’d like it to. Focus on manifestations, not yet on explanations.What is your interpretation?
Give a traceable explanation of your believes of why the issue arose. If you aren’t accusatory, this can give your counterpart a chance to correct your reasoning.How would you suggest to fix it?
State these suggestions as a form of personal belief—because they are. It is helpful to show your approach in detail, without defending it or arguing for it.Explain the reasoning of your fix.
Separating this from step 3 allows you to argue in a less emotional way, describing your deductions in an almost mechanical matter. This often helps you spot where your suggestion relies on personal beliefs as well.Show you made it easy to apply.
This step firstly consists of making your suggestion easy to implement. Set up a new schedule for that meeting. Just like you write a pull request that can be merged without conflicts and test coverage on par with the standard for the project you contribute to. The idea is to make it easier to accept your suggestion than to reject it. You’re- vercoming status-quo bias here, so be prepared to invest a lot of effort.
A DVCS pull request approach to personal feedback
Pull Request Feedback
ludwig@schubert.io
+
SLIDE 12
Thank You.
For your feedback: @ludwigschubert ludwig@schubert.io
SLIDE 13
How does the issue manifest? What is your interpretation? How would you suggest to fix it? Explain the reasoning of your fix. Show you made it easy to apply.
FREE META LEVEL!
SLIDE 14