Code review-review is the managers job @johnbarton Make time - - PowerPoint PPT Presentation

▶
code review review is the manager s job
SMART_READER_LITE
LIVE PREVIEW

Code review-review is the managers job @johnbarton Make time - - PowerPoint PPT Presentation

Jan 12, 2024 41 likes •275 views

Code review-review is the managers job @johnbarton Make time (nearly) every day to systematically review (nearly) all your teams pull requests Standard Disclaimers This is all post hoc rationalisation of me doing what I wanted

slide-1
SLIDE 1

Code review-review is the manager’s job

@johnbarton

slide-2
SLIDE 2

Make time (nearly) every day to systematically review (nearly) all your team’s pull requests

slide-3
SLIDE 3

Standard Disclaimers

  • This is all post hoc rationalisation of me

doing what I wanted while luck played its always critical role

  • There is a smoothing of narrative and an

aspirational high water mark I never reached anyway

slide-4
SLIDE 4
slide-5
SLIDE 5
slide-6
SLIDE 6

Code review is an engineering task

slide-7
SLIDE 7
slide-8
SLIDE 8
slide-9
SLIDE 9 Building Healthy Organisational Incentives https://medium.com/@kswanson/bu ilding-healthy-organizational-incenti ves-91b051c57b76 Culture is the Behavior You Reward and Punish https://jocelyngoldfein.com/culture-i s-the-behavior-you-reward-and-punis h-7e8e75c6543e
slide-10
SLIDE 10

現場

[Gemba]

slide-11
SLIDE 11
slide-12
SLIDE 12
slide-13
SLIDE 13
slide-14
SLIDE 14 Process & Collaboration Technical Outcome
slide-15
SLIDE 15 Process & Collaboration Technical Outcome

What are Rockstars Doing Today? The Downward Spiral Gold Comfort Eagle

slide-16
SLIDE 16
slide-17
SLIDE 17
slide-18
SLIDE 18
slide-19
SLIDE 19
slide-20
SLIDE 20
slide-21
SLIDE 21
slide-22
SLIDE 22

if (convinced) { days.map((day) => { let thoughts = reviewPRs(day); saveToDiary(thoughts); nudgeTeam(thoughts); } }

slide-23
SLIDE 23

visit(“hecate.co”); follow(“@johnbarton”);