squash that old bug
play

Squash That Old Bug Daniel Black Daniel Black IBM IBM Overview - PowerPoint PPT Presentation

Sep 17, 2023 •48 likes •398 views

Squash That Old Bug Daniel Black Daniel Black IBM IBM Overview Topics: Topics: Choosing a bug/feature Choosing a bug/feature Build/test environment Build/test environment Tour of code base Tour of code base

  1. Squash That Old Bug Daniel Black Daniel Black IBM IBM

  2. Overview Topics: Topics: • Choosing a bug/feature • Choosing a bug/feature • Build/test environment • Build/test environment • Tour of code base • Tour of code base • Build/test • Build/test • Submitting code • Submitting code • Asking for help • Asking for help 2

  3. Choosing a Bug / Feature (MySQL) Search existing bugs Search existing bugs https://bugs.mysql.com/search.php https://bugs.mysql.com/search.php Status: Verifjed Status: Verifjed Note: (Efgort/Risk fjelds have fallen out of use) Note: (Efgort/Risk fjelds have fallen out of use) 3

  4. Choosing a Bug / Feature (MariaDB) Search existing bugs Search existing bugs jql: status = Confjrmed jql: status = Confjrmed jql: labels = beginner-friendly jql: labels = beginner-friendly 4

  5. Choosing a Bug / Feature - Easy ● Regressions ● Regressions ● Wrong result ● Wrong result ● Portability (e.g. fix for FreeBSD) ● Portability (e.g. fix for FreeBSD) ● Enhancement for new Linux Kernel API ● Enhancement for new Linux Kernel API ● Client tools (mysql, mysqldump/pump) ● Client tools (mysql, mysqldump/pump) ● New SQL functions (verified / follow standard) ● New SQL functions (verified / follow standard) 5

  6. Choosing a Bug / Feature - Hard ● Group / GTID replication ● Group / GTID replication ● Optimizer ● Optimizer Or if you must: Or if you must: – Easy/quick to calculate (low overhead) – Easy/quick to calculate (low overhead) – Always an improvement (no regressions) – Always an improvement (no regressions) 6

  7. Build / Test environment Few dependencies: Few dependencies: ● Git ● Git ● Cmake ● Cmake ● C++ compiler: gcc/ clang/ Xcode / VS17 ● C++ compiler: gcc/ clang/ Xcode / VS17 ● Bison ● Bison ● Ncurses ● Ncurses ● Libevent (MariaDB) / boost (MySQL) ● Libevent (MariaDB) / boost (MySQL) Ref: https://mariadb.com/kb/en/library/compiling-mariadb-from-source/ Ref: https://mariadb.com/kb/en/library/compiling-mariadb-from-source/ https://dev.mysql.com/doc/mysql-sourcebuild-excerpt/8.0/en/ https://dev.mysql.com/doc/mysql-sourcebuild-excerpt/8.0/en/ 7

  8. Build / Test environment Github: https://github.com/MariaDB/server/ Github: https://github.com/MariaDB/server/ repos]$ git clone git@github.com:grooverdan/mariadb-server.git repos]$ git clone git@github.com:grooverdan/mariadb-server.git 8

  9. Build / Test environment mariadb-server]$ cd ../build-mariadb-server mariadb-server]$ cd ../build-mariadb-server build-mariadb-server]$ cmake -DCMAKE_BUILD_TYPE=Debug ../mariadb-server build-mariadb-server]$ cmake -DCMAKE_BUILD_TYPE=Debug ../mariadb-server -- Running cmake version 3.14.3 -- Running cmake version 3.14.3 -- The C compiler identification is GNU 9.1.1 -- The C compiler identification is GNU 9.1.1 -- The CXX compiler identification is GNU 9.1.1 -- The CXX compiler identification is GNU 9.1.1 ... ... -- Configuring done -- Configuring done -- Generating done -- Generating done -- Build files have been written to: /home/dan/repos/build-mariadb-server -- Build files have been written to: /home/dan/repos/build-mariadb-server build-mariadb-server]$ make -j8 build-mariadb-server]$ make -j8 Scanning dependencies of target abi_check Scanning dependencies of target abi_check 9 Scanning dependencies of target wsrep_api_v26 Scanning dependencies of target wsrep_api_v26

  10. Tour of codebase 1 0

  11. Example Bug 71386 SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); null null SHOW WARNINGS SHOW WARNINGS Warning | 1411 | Incorrect datetime value: '01:35 PM' for function Warning | 1411 | Incorrect datetime value: '01:35 PM' for function str_to_date str_to_date 1 1

  12. Create a Test Case mysql-server]$ git grep -l STR_TO_DATE mysql-test/ mysql-server]$ git grep -l STR_TO_DATE mysql-test/ mysql-test/r/date_formats.result mysql-test/r/date_formats.result mysql-test/r/func_time.result mysql-test/r/func_time.result ... ... mysql-test/t/date_formats.test mysql-test/t/date_formats.test mysql-test/t/func_time.test mysql-test/t/func_time.test mysql-test/t/ignore_strict.test mysql-test/t/ignore_strict.test mysql-test/t/parser.test mysql-test/t/parser.test mysql-test/t/strict.test mysql-test/t/strict.test mysql-test/t/type_datetime.test mysql-test/t/type_datetime.test mysql-test/t/type_temporal_fractional.test mysql-test/t/type_temporal_fractional.test 1 2

  13. Create a Test Case mysql-server]$ cat mysql-test/t/bug71386.test mysql-server]$ cat mysql-test/t/bug71386.test SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); build-mysql-8.0]$ mysql-test/mtr bug71386 build-mysql-8.0]$ mysql-test/mtr bug71386 … … ----------- MYSQLTEST OUTPUT START ----------- ----------- MYSQLTEST OUTPUT START ----------- SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); STR_TO_DATE('01:35 PM', '%h:%i %p') STR_TO_DATE('01:35 PM', '%h:%i %p') NULL NULL Warnings: Warnings: Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date 1 3

  14. Create a Test Case build-mysql-8.0]$ mysql-test/mtr --ddd bug71386 build-mysql-8.0]$ mysql-test/mtr --ddd bug71386 1 4

  15. Find the Cause mysql-server] $ git grep -B 1 "' for function " mysql-server] $ git grep -B 1 "' for function " share/errmsg-utf8.txt-ER_WRONG_VALUE_FOR_TYPE share/errmsg-utf8.txt-ER_WRONG_VALUE_FOR_TYPE share/errmsg-utf8.txt: eng "Incorrect %-.32s value: '%-.128s' for function share/errmsg-utf8.txt: eng "Incorrect %-.32s value: '%-.128s' for function %-.32s" %-.32s" 1 5

  16. Find the Cause mysql-server]$ git grep -l ER_WRONG_VALUE_FOR_TYPE mysql-server]$ git grep -l ER_WRONG_VALUE_FOR_TYPE mysql-test/include/ctype_inet.inc mysql-test/include/ctype_inet.inc .. .. mysql-test/t/window_functions.test mysql-test/t/window_functions.test share/errmsg-utf8.txt share/errmsg-utf8.txt sql/error_handler.cc sql/error_handler.cc sql/item_func.cc sql/item_func.cc sql/item_geofunc.cc sql/item_geofunc.cc sql/item_inetfunc.cc sql/item_inetfunc.cc sql/item_strfunc.cc sql/item_strfunc.cc sql/item_timefunc.cc sql/item_timefunc.cc 1 6

  17. Find the Cause “Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date” “Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date” static bool extract_date_time(const Date_time_format *format, const char static bool extract_date_time(const Date_time_format *format, const char *val…. *val…. 1 7

  18. Find the Cause “Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date” “Warning 1411 Incorrect datetime value: '01:35 PM' for function str_to_date” bool Item_func_str_to_date::val_datetime(MYSQL_TIME *ltime, bool Item_func_str_to_date::val_datetime(MYSQL_TIME *ltime, my_time_flags_t fuzzy_date) { my_time_flags_t fuzzy_date) { 1 8

  19. Find the Cause 1 9

  20. Find the Cause 2 0

  21. Find the Cause 2 1

  22. Find the Cause 2 2

  23. Find the Cause 2 3

  24. Find the Cause mysql-server]$ cat ./mysql-test/t/bug71386.test SELECT STR_TO_DATE('1/1/2010', '%m/%d/%Y'); SELECT STR_TO_DATE('1/1/2010 01:35 PM', '%m/%d/%Y %h:%i %p'); SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); ; Thread 42 "mysqld" hit Breakpoint 2, Item_func_str_to_date::val_datetime (this=0x7fff941064e8, ltime=0x7fffec06d510, fuzzy_date=1) at /home/dan/repos/mysql- server/sql/item_timefunc.cc:3059 (gdb) p data_type() $1 = MYSQL_TYPE_DATE (gdb) cont Continuing. (gdb) p data_type() $2 = MYSQL_TYPE_DATETIME (gdb) cont Continuing. (gdb) p data_type() $3 = MYSQL_TYPE_TIME 2 4

  25. A Solution ; 2 5

  26. Test Solution build-mysql-8.0]$ mysql-test/mtr bug71386 build-mysql-8.0]$ mysql-test/mtr bug71386 … … ----------- MYSQLTEST OUTPUT START ----------- ----------- MYSQLTEST OUTPUT START ----------- SELECT STR_TO_DATE('1/1/2010', '%m/%d/%Y'); SELECT STR_TO_DATE('1/1/2010', '%m/%d/%Y'); STR_TO_DATE('1/1/2010', '%m/%d/%Y') STR_TO_DATE('1/1/2010', '%m/%d/%Y') 2010-01-01 2010-01-01 SELECT STR_TO_DATE('1/1/2010 01:35 PM', '%m/%d/%Y %h:%i %p'); SELECT STR_TO_DATE('1/1/2010 01:35 PM', '%m/%d/%Y %h:%i %p'); STR_TO_DATE('1/1/2010 01:35 PM', '%m/%d/%Y %h:%i %p') STR_TO_DATE('1/1/2010 01:35 PM', '%m/%d/%Y %h:%i %p') 2010-01-01 13:35:00 2010-01-01 13:35:00 SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); SELECT STR_TO_DATE('01:35 PM', '%h:%i %p'); STR_TO_DATE('01:35 PM', '%h:%i %p') STR_TO_DATE('01:35 PM', '%h:%i %p') 2 6 13:35:00 13:35:00

Download Presentation
Download Policy: The content available on the website is offered to you 'AS IS' for your personal information and use only. It cannot be commercialized, licensed, or distributed on other websites without prior consent from the author. To download a presentation, simply click this link. If you encounter any difficulties during the download process, it's possible that the publisher has removed the file from their server.

Recommend

The Project Manager as Godzilla Learn to Squash more bugs more quickly Session Goals

The Project Manager as Godzilla Learn to Squash more bugs more quickly Session Goals

The Project Manager as Godzilla Learn to Squash more bugs more quickly Session Goals Introduction to tactics and tools to streamline and improve your debugging process so you can squash bugs and reign joy and efficiency on your

193 views • 15 slides
The Three Sisters The Three Sisters are Corn (Maize) , Beans , and Squash These three

The Three Sisters The Three Sisters are Corn (Maize) , Beans , and Squash These three

The Three Sisters The Three Sisters are Corn (Maize) , Beans , and Squash These three foods are a food thats been eaten on this land for many, many years. Not only do they have famous legends attached to them, but they also work

247 views • 13 slides
Lincolnshire Squash Presentation Night 2018 Visit our website at www.lincolnshiresquash.co.uk

Lincolnshire Squash Presentation Night 2018 Visit our website at www.lincolnshiresquash.co.uk

Lincolnshire Squash Presentation Night 2018 Visit our website at www.lincolnshiresquash.co.uk Evening All, Id like to start by welcoming everyone to this evenings presentation night to celebrate the end of what has been a positive season

307 views • 27 slides
Static Java Program Features for Intelligent Squash Prediction Jeremy Singer, Paraskevas

Static Java Program Features for Intelligent Squash Prediction Jeremy Singer, Paraskevas

Static Java Program Features for Intelligent Squash Prediction Jeremy Singer, Paraskevas Yiapanis, Adam Pocock, Mikel Lujan, Gavin Brown, Nikolas Ioannou, and Marcelo Cintra 1 University of Manchester, UK jsinger@cs.man.ac.uk 2 University of

152 views • 12 slides
Q U A L I T Y F R U I T D R I N K S S I N C E 1 9 3 7 Our History Established in 1937, Tovali

Q U A L I T Y F R U I T D R I N K S S I N C E 1 9 3 7 Our History Established in 1937, Tovali

Q U A L I T Y F R U I T D R I N K S S I N C E 1 9 3 7 Our History Established in 1937, Tovali is a second generation family run independent squash and cordial manufacturer in the UK. Set up in the ancient town of Carmarthen in the Towy

508 views • 9 slides
Portsmouth in the Time of the Settlers Before the Settlers Came Aquidneck Island was used as a

Portsmouth in the Time of the Settlers Before the Settlers Came Aquidneck Island was used as a

Portsmouth in the Time of the Settlers Before the Settlers Came Aquidneck Island was used as a summer camp ground for Wampanoag and Narragansett families. The men hunted and fished our shores The women planted crops. Corn, beans and squash

304 views • 16 slides
2019 2019 ESSEX ESS EX SRA SRA AGM GM & COU COUNT NTY Y LEA LEAGU GUE E ME MEET

2019 2019 ESSEX ESS EX SRA SRA AGM GM & COU COUNT NTY Y LEA LEAGU GUE E ME MEET

Essex Squash & Racketball Association 2019 2019 ESSEX ESS EX SRA SRA AGM GM & COU COUNT NTY Y LEA LEAGU GUE E ME MEET ETINGS INGS Also Includes : Havering Barking & Dagenham Newham Redbridge Waltham Forrest July

850 views • 57 slides
Where learning is: Innovative Individualised Connected GREEN BAY AIRPORT NEW

Where learning is: Innovative Individualised Connected GREEN BAY AIRPORT NEW

Where learning is: Innovative Individualised Connected GREEN BAY AIRPORT NEW LYNN SHOPPING MALL & TRANSPORT HUB GOLF CLUB SOCCER CLUB TENNIS & SQUASH CLUB GREEN BAY HIGH SCHOOL ART GALLERY LIVE THEATRE FRENCH

287 views • 25 slides
An Introduction to Physical Literacy Dr Cara Shearer c.shearer@2016.ljmu.ac.uk @Cara_Shearer94

An Introduction to Physical Literacy Dr Cara Shearer c.shearer@2016.ljmu.ac.uk @Cara_Shearer94

An Introduction to Physical Literacy Dr Cara Shearer c.shearer@2016.ljmu.ac.uk @Cara_Shearer94 Post-doctoral Researcher: Liverpool John Moores University Development Officer for Women and Girls: Scottish Squash Board member (research):

270 views • 16 slides
1 Squash and Stretch Principles of Traditional Animation Principles of Traditional Animation

1 Squash and Stretch Principles of Traditional Animation Principles of Traditional Animation

To Do To Do Foundations of Computer Graphics Foundations of Computer Graphics Submit HW 4 (today) (Spring 2010) (Spring 2010) Start working on HW 5 (can be simple add-on) CS 184, Lecture 24: Animation

231 views • 6 slides
From Mulch to Camp: Summer Garden Care Strategies for management and success! Presented by:

From Mulch to Camp: Summer Garden Care Strategies for management and success! Presented by:

From Mulch to Camp: Summer Garden Care Strategies for management and success! Presented by: Hope Guardenier, School Sprouts Calin Duke, Sustainable Nantucket What to plant for a low maintenance summer Potatoes Carrots Squash

341 views • 17 slides
Be the One: Building Resilient Children & Families Presenters: Pam Leo (Book Fairy Pantry

Be the One: Building Resilient Children & Families Presenters: Pam Leo (Book Fairy Pantry

Be the One: Building Resilient Children & Families Presenters: Pam Leo (Book Fairy Pantry Project); Barrett Takesian (Portland Community Squash); Brittney Sampson (Westbrook Neighborhood Hub) Moderator: Barrett Wilkinson (Portland Public

278 views • 16 slides
Executable Formal Models in Rewriting Logic Carolyn Talcott RTA 2015 1 Formal Executable Models

Executable Formal Models in Rewriting Logic Carolyn Talcott RTA 2015 1 Formal Executable Models

Executable Formal Models in Rewriting Logic Carolyn Talcott RTA 2015 1 Formal Executable Models For design, prototyping, analysis. To clarify ideas, squash insidious bugs early on many bugs / flaws can be found by just formalizing

669 views • 50 slides
Logical and Meta-Logical Frameworks Frank Pfenning Marktoberdorf Summer School 2001 July

Logical and Meta-Logical Frameworks Frank Pfenning Marktoberdorf Summer School 2001 July

Logical and Meta-Logical Frameworks Frank Pfenning Marktoberdorf Summer School 2001 July 25-August 4, 2001 1.1 First Things First If you play squash see me after lecture! 1.2 Outline of Four Lectures Lecture 1 : Higher-Order Abstract

1.51k views • 138 slides
& COUN COUNTY TY REPOR REPORT Brian Clark David Neller Includes : London Hon Secretary,

& COUN COUNTY TY REPOR REPORT Brian Clark David Neller Includes : London Hon Secretary,

Essex Squash & Racketball Association 2012 2012 Lea League gue Meetings, Meetings, AGM GM & COUN COUNTY TY REPOR REPORT Brian Clark David Neller Includes : London Hon Secretary, ESRA Chairman, ESRA Boroughs June 2012 Club

599 views • 45 slides
OFFICIATING PROGRAM DOUBLES CERTIFICATION CLINIC The material presented in these slides is from

OFFICIATING PROGRAM DOUBLES CERTIFICATION CLINIC The material presented in these slides is from

OFFICIATING PROGRAM DOUBLES CERTIFICATION CLINIC The material presented in these slides is from the Squash Canada Doubles Officiating Certification Program. The material in these slides may not be reproduced or used in any manner without the

792 views • 44 slides
Outline 1. Principles of Traditional Animation Applied to Computer Animation Animation

Outline 1. Principles of Traditional Animation Applied to Computer Animation Animation

Outline 1. Principles of Traditional Animation Applied to Computer Animation Animation (Lasseter, 1987) 2. Animation: Can it facilitate? (Tversky and Morrison, 2002) Presented By Timothy Chan 3. On Creating Animated Presentations (Zongker

541 views • 9 slides
Elementary amenable groups are quasidiagonal Joint work with N. Ozawa and M. Rrdam 20, June,

Elementary amenable groups are quasidiagonal Joint work with N. Ozawa and M. Rrdam 20, June,

Elementary amenable groups are quasidiagonal Elementary amenable groups are quasidiagonal Joint work with N. Ozawa and M. Rrdam 20, June, 2014. Toronto . . . . . . Elementary amenable groups are quasidiagonal Q.D. Quasi Diagonal C

597 views • 25 slides
Main and Subordinate Clauses Main Clauses: The Rules A main clause is a group of words that

Main and Subordinate Clauses Main Clauses: The Rules A main clause is a group of words that

Main and Subordinate Clauses Main Clauses: The Rules A main clause is a group of words that contains a verb and a subject which makes complete sense on its own . Main clauses could also be called simple sentences . Can you spot the verbs and

243 views • 11 slides
Spaces of phylogenetic networks Jonathan Klawitter PhD Exam 5th March, 2020 2 - 1

Spaces of phylogenetic networks Jonathan Klawitter PhD Exam 5th March, 2020 2 - 1

1 Spaces of phylogenetic networks Jonathan Klawitter PhD Exam 5th March, 2020 2 - 1 Phylogenetic trees & networks 2 - 2 Phylogenetic trees & networks 2 - 3 Phylogenetic trees & networks T 1 2 3 4 5 6 2 - 4

604 views • 48 slides
Fully Homomorphic Encryption from Ring-LWE and Security for Key Dependent Messages Zvika

Fully Homomorphic Encryption from Ring-LWE and Security for Key Dependent Messages Zvika

Fully Homomorphic Encryption from Ring-LWE and Security for Key Dependent Messages Zvika Brakerski Vinod Vaikuntanathan (Weizmann) (University of Toronto) CRYPTO 2011 Outsourcing Computation x Function x f f ( x ) medical records

520 views • 15 slides
Page 1 of 3-1 Prof. JLF King (init-moduli 5 13 17) = (221 170 -390) *BIGM* = 1105 (bigp4tup

Page 1 of 3-1 Prof. JLF King (init-moduli 5 13 17) = (221 170 -390) *BIGM* = 1105 (bigp4tup

Page 1 of 3-1 Prof. JLF King (init-moduli 5 13 17) = (221 170 -390) *BIGM* = 1105 (bigp4tup (2 -5 -4)) = 47 (bigp4tup (2 -5 4)) = 242 (bigp4tup (2 5 4)) = -268 (bigp4tup (2 5 -4)) = -463 (mod (* 463 463) 1105) = 1104

192 views • 3 slides
Logistics Test e-mail Animation Principles Anyone not get it? Office Hours Monday

Logistics Test e-mail Animation Principles Anyone not get it? Office Hours Monday

Logistics Test e-mail Animation Principles Anyone not get it? Office Hours Monday 2-3 okay 3-4 cancelled Projects Plan for today Reminders Principles of Animation Reminder that proposal is due before break.

490 views • 7 slides
Formalizing Type Operations Using the Image Type Constructor Aleksey Nogin and Alexei

Formalizing Type Operations Using the Image Type Constructor Aleksey Nogin and Alexei

Formalizing Type Operations Using the Image Type Constructor Aleksey Nogin and Alexei Kopylov California Institute of Technology WoLLIC, 2006 WoLLIC06 Aleksey Nogin, Alexei Kopylov Image Type p. 1 Introduction Set theory

616 views • 26 slides

More recommend