SLIDE 1
PROPRIETARY AND CONFIDENTIAL
Contributing to Zeek
Tim Wojtulewicz, Corelight
PROPRIETARY AND CONFIDENTIAL
If you were confused by all of the consonants jammed together
Contributing to Zeek Tim Wojtulewicz, Corelight PROPRIETARY AND - - PowerPoint PPT Presentation
Contributing to Zeek Tim Wojtulewicz, Corelight PROPRIETARY AND - - PowerPoint PPT Presentation
Contributing to Zeek Tim Wojtulewicz, Corelight PROPRIETARY AND CONFIDENTIAL Thats Woah-2-la-wits If you were confused by all of the consonants jammed together PROPRIETARY AND CONFIDENTIAL Talking today about how to open pull requests
SLIDE 2
SLIDE 3
PROPRIETARY AND CONFIDENTIAL
Talking today about how to open pull requests for Zeek issues
SLIDE 4
PROPRIETARY AND CONFIDENTIAL
Picking an issue (optional)
SLIDE 5
PROPRIETARY AND CONFIDENTIAL
Fork the repo
SLIDE 6
PROPRIETARY AND CONFIDENTIAL
Clone the repo
git clone git@github.com:zeek/zeek.git
SLIDE 7
PROPRIETARY AND CONFIDENTIAL
Configure and build
cd zeek ./configure --prefix=/some/path cd build make
SLIDE 8
PROPRIETARY AND CONFIDENTIAL
This is the part where you open emacs and fix the issue
SLIDE 9
PROPRIETARY AND CONFIDENTIAL
You are using emacs, right?
SLIDE 10
PROPRIETARY AND CONFIDENTIAL
Run the tests
cd testing/btest btest -j 6 If it succeeds: 981 tests successful, 67 skipped Don’t worry about those skipped tests, that’s intentional.
SLIDE 11
PROPRIETARY AND CONFIDENTIAL
git checkout -b <branchname> git commit -a -m “GH-###: Some descriptive commit message” git push -u origin -b <branchname> The GH-### part will cause Github to automatically close the issue when the PR is merged.
Commit your change to your fork
SLIDE 12
PROPRIETARY AND CONFIDENTIAL
Create the pull request, part 1
SLIDE 13
PROPRIETARY AND CONFIDENTIAL
Create the pull request, part 2
SLIDE 14
PROPRIETARY AND CONFIDENTIAL
Create the pull request, part 3
SLIDE 15
PROPRIETARY AND CONFIDENTIAL
Wait for someone to review
SLIDE 16
PROPRIETARY AND CONFIDENTIAL
Review feedback -> fixes -> new commits -> more reviews
SLIDE 17
PROPRIETARY AND CONFIDENTIAL
Maintainer will merge to master
SLIDE 18
PROPRIETARY AND CONFIDENTIAL