the impact of code review coverage and code review
play

The Impact of Code Review Coverage and Code Review Participation on - PowerPoint PPT Presentation

Feb 02, 2023 •711 likes •1.62k views

The Impact of Code Review Coverage and Code Review Participation on Software Quality Shane Yasutaka Bram Ahmed E. McIntosh Kamei Adams Hassan Code reviews : An opportunity for constructive criticism of code changes Yasu Shane Bram

  1. The Impact of Code Review Coverage and Code Review Participation on Software Quality Shane Yasutaka Bram Ahmed E. McIntosh Kamei Adams Hassan

  2. Code reviews : An opportunity for constructive criticism of code changes Yasu Shane Bram � 2

  3. Code reviews : An opportunity for constructive criticism of code changes + + - Yasu - Patch Shane Bram � 2

  4. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? + Yasu + - - Shane Patch Bram � 2

  5. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? No way, Shane! + Yasu + - - Shane Patch Bram � 2

  6. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? No way, Shane! + Yasu + - - Shane Patch Your code sucks! Bram � 2

  7. Code reviews : An opportunity for constructive criticism of code changes Yasu Shane Bram � 3

  8. Code reviews : An opportunity for constructive criticism of code changes + + - Yasu - Patch Shane Bram � 3

  9. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? Yasu + + Shane - - Patch Bram � 3

  10. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? Watch about NULL values at line 3! Yasu + + Shane - - Patch Bram � 3

  11. Code reviews : An opportunity for constructive criticism of code changes Bram and Yasu, I made a code change. Could you have a look? Watch about NULL values at line 3! Yasu + + Shane - - Patch Your code still sucks! Bram � 3

  13. Traditional � Code Inspections Mandated reviewer checklists and in-person meetings

  14. Traditional � Code Inspections Measurably � improves � software � quality Mandated reviewer checklists and in-person meetings

  15. Traditional � Modern � Code Inspections Code Review Measurably � improves � software � quality Mandated reviewer checklists and in-person Lightweight, tool-supported meetings

  16. Traditional � Modern � Code Inspections Code Review Measurably � improves � ??? software � quality Mandated reviewer checklists and in-person Lightweight, tool-supported meetings

  17. Are properties of the modern code review process linked to software quality? � 5

  18. Are properties of the modern code review process linked to software quality? Coverage � 5

  19. Are properties of the modern code review process linked to software quality? Coverage Participation � 5

  20. Are properties of the modern code review process linked to software quality? � 6

  21. Gerrit Code Review Process + + Yasu + + - - - - Patch Patch Shane Gerrit Bram � 7

  22. Gerrit Code Review Process + Yasu + - + - + Patch - - Shane Gerrit Patch Bram � 7

  23. Gerrit Code Review Process + Yasu + - Request + - + Patch review - - Shane Gerrit Patch Bram � 7

  24. Gerrit Code Review Process Watch about NULL values at line 3! + Yasu + - + - + Patch - - Shane Gerrit Patch Bram � 7

  25. Gerrit Code Review Process Watch about NULL values at line 3! + Yasu + - + - + Patch - - Shane Gerrit Patch Your code sucks! Bram � 7

  26. Gerrit Code Review Process Watch about NULL values at line 3! Yasu + + + + - - - - Shane Gerrit Patch Patch Your code sucks! Bram � 7

  27. Gerrit Code Review Process Yasu Shane Gerrit Bram � 8

  28. Gerrit Code Review Process Yasu Shane Gerrit Bram � 8

  29. Gerrit Code Review Process Upstream Yasu Shane Gerrit Bram � 8

  30. Gerrit Code Review Process Changes are automatically Upstream integrated after review Yasu criteria are satisfied Shane Gerrit Bram � 8

  31. Reviews can be linked to commits in source code repositories commit b5b46f398c1a04ab443bf22ec08c5efbf72c161e Author: Alan Alpert <alan.alpert@nokia.com> Date: Thu Mar 1 20:09:52 2012 +1000 � Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Upstream Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com> Gerrit � 9

  32. Reviews can be linked to commits in source code repositories commit b5b46f398c1a04ab443bf22ec08c5efbf72c161e Author: Alan Alpert <alan.alpert@nokia.com> Date: Thu Mar 1 20:09:52 2012 +1000 � Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Upstream Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com> Gerrit � 9

  33. Reviews can be linked to commits in source code repositories commit b5b46f398c1a04ab443bf22ec08c5efbf72c161e Author: Alan Alpert <alan.alpert@nokia.com> Date: Thu Mar 1 20:09:52 2012 +1000 � Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Upstream Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com> Gerrit � 9

  34. Reviews can be linked to commits in source code repositories commit b5b46f398c1a04ab443bf22ec08c5efbf72c161e Author: Alan Alpert <alan.alpert@nokia.com> Date: Thu Mar 1 20:09:52 2012 +1000 � Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Upstream Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com> Gerrit � 9

  35. Are properties of the modern code review process linked to software quality ? � 10

  36. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream Release Development � 11

  37. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream Release Development � 11

  38. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream Release Development � 11

  39. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream Release Development � 11

  40. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream v1.0 Release Development � 11

  41. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream v1.0 Release Development � 11

  42. Software Quality as Post-Release Defect Counts Commit types Feature development Defect repairing Merge Upstream v1.0 Release Development � 11

  43. Defect Models Comp. A How many Comp. B defects? Comp. C � 12

  44. Defect Models 0 Comp. A How many 1 Comp. B defects? 5 Comp. C � 12

  45. Explanatory Defect Models v1.0 Release Development � 13

  46. Explanatory Defect Models Defect model v1.0 Release Development � 13

  47. Explanatory Defect Models Defect model v1.0 � 14

  48. Explanatory Defect Models Analyze relationship between Defect model v1.0 predictors and defects � 14

  49. The Baseline � 15

  50. Product Metrics The Baseline � 15

  51. Product Metrics The Baseline e.g., SLOC, complexity � 15

  52. Product Metrics The Baseline e.g., SLOC, complexity Process Metrics � 15

  53. Product Metrics The Baseline e.g., SLOC, complexity Process Metrics e.g., Prior defects, churn � 15

  54. Product Metrics The Baseline e.g., SLOC, complexity Process Metrics e.g., Prior defects, churn Human Factors Metrics � 15

  55. Product Metrics The Baseline e.g., SLOC, complexity Process Metrics e.g., Prior defects, churn Human Factors Metrics e.g., # Minor contributors � 15

  56. The Context � 16

  57. v5.0.0 The Context 1,339 components 254 defect-prone v5.1.0 1,337 components 187 defect-prone � 16

  58. v5.0.0 The Context 1,339 components 254 defect-prone v5.1.0 1,337 components 187 defect-prone v5.10.0 170 components 15 defect-prone � 16

  59. v5.0.0 The Context 1,339 components 254 defect-prone v5.1.0 1,337 components 187 defect-prone v5.10.0 170 components 15 defect-prone v4.3.0 218 components 24 defect-prone � 16

  60. Are properties of the code reviewing process linked to software quality? Coverage Participation

  61. Are properties of the code reviewing process linked to software quality? Coverage Participation � 18

  62. Are properties of the code reviewing process linked to software quality? Metrics � � Reviewed changes (%) Reviewed churn (%) Coverage Participation � 18

Download Presentation
Download Policy: The content available on the website is offered to you 'AS IS' for your personal information and use only. It cannot be commercialized, licensed, or distributed on other websites without prior consent from the author. To download a presentation, simply click this link. If you encounter any difficulties during the download process, it's possible that the publisher has removed the file from their server.

Recommend

Gerrit Code Review Web based code review and project management for Git based projects Johannes

Gerrit Code Review Web based code review and project management for Git based projects Johannes

Gerrit Code Review Web based code review and project management for Git based projects Johannes Barop gateprotect AG Germany Agenda Agenda Why Code Reviews? Why a Dedicated Tool for Reviews? Googles Web Code Review Tools

435 views • 42 slides
Code Coverage Outlines Code Coverage. EMMA Installing EMMA Running EMMA View

Code Coverage Outlines Code Coverage. EMMA Installing EMMA Running EMMA View

Code Coverage Outlines Code Coverage. EMMA Installing EMMA Running EMMA View Result Code Coverage Is a measure used in software testing. It describes the degree to which the source code of a program has been tested.

678 views • 21 slides
S oftware C raftmanship Z rich How to not suck at Code Reviews ;-) Survey time! Code Quality -

S oftware C raftmanship Z rich How to not suck at Code Reviews ;-) Survey time! Code Quality -

S oftware C raftmanship Z rich How to not suck at Code Reviews ;-) Survey time! Code Quality - Happy? Code Reviews @ Job? Commit Review? Pull Review? vs. Code Review? Who is reviewing their own code? Agenda aka The plan 1. Exercise

685 views • 34 slides
EFFECTIVE CODE REVIEW EFFECTIVE CODE REVIEW Who am I? @d0ugal Raise your hand Not

EFFECTIVE CODE REVIEW EFFECTIVE CODE REVIEW Who am I? @d0ugal Raise your hand Not

EFFECTIVE CODE REVIEW EFFECTIVE CODE REVIEW Who am I? @d0ugal Raise your hand Not doing code review? the average defect detection rate is only 25 percent for unit testing, 35 percent for function testing, and 45 percent for

835 views • 45 slides
Using the Code Review Module Szeged DrupalCon Using the Code Review Module Doug Green Stella

Using the Code Review Module Szeged DrupalCon Using the Code Review Module Doug Green Stella

Using the Code Review Module Szeged DrupalCon Using the Code Review Module Doug Green Stella Power doug@civicactions.com stella@stellapower.net Using the Code Review Module Coder Module Overview History Developer Module, built

566 views • 23 slides
Review Ch 1-5 Executing code Compile code (convert from C++ to computer code) - Syntax errors

Review Ch 1-5 Executing code Compile code (convert from C++ to computer code) - Syntax errors

Review Ch 1-5 Executing code Compile code (convert from C++ to computer code) - Syntax errors will prevent compilation Run code - Runtime errors will crash your program - Logic errors will make your program give the wrong output Syntax =

192 views • 15 slides
Code review-review is the managers job @johnbarton Make time (nearly) every day to

Code review-review is the managers job @johnbarton Make time (nearly) every day to

Code review-review is the managers job @johnbarton Make time (nearly) every day to systematically review (nearly) all your teams pull requests Standard Disclaimers This is all post hoc rationalisation of me doing what I wanted

271 views • 23 slides
Code Coverage SWEN-261 Introduction to Software Engineering Department of Software Engineering

Code Coverage SWEN-261 Introduction to Software Engineering Department of Software Engineering

Code Coverage SWEN-261 Introduction to Software Engineering Department of Software Engineering Rochester Institute of Technology Code coverage analysis is measuring how well your unit tests exercise the production code. Code coverage

290 views • 10 slides
Creation of a Serious Game For Teaching Code Review Presenter: Bar Ard Bar Ard

Creation of a Serious Game For Teaching Code Review Presenter: Bar Ard Bar Ard

Creation of a Serious Game For Teaching Code Review Presenter: Bar Ard Bar Ard rem Yurdakul Eray Tzn Outline I. Serious Games II. Code Review Process III. Workflow of the study IV. Learning Objectives V. Game Flow

315 views • 16 slides
Review of the Code of Accounting Practice and Financial Reporting (the Code) Update 28 2019-20

Review of the Code of Accounting Practice and Financial Reporting (the Code) Update 28 2019-20

Review of the Code of Accounting Practice and Financial Reporting (the Code) Update 28 2019-20 Welcome Introductions and purpose of the web video OLG Contents of this presentation Financial reporting governance structures and the Code

425 views • 41 slides
When testing meets Code Review: Why and How Developers Review Tests Davide Spadini, Mauricio

When testing meets Code Review: Why and How Developers Review Tests Davide Spadini, Mauricio

When testing meets Code Review: Why and How Developers Review Tests Davide Spadini, Mauricio Aniche, Margaret-Anne Storey, Magiel Bruntink, Alberto Bacchelli When testing meets Code Review: Why and How Developers Review Tests Davide Spadini ,

966 views • 41 slides
CODE COVERAGE ISNT COVERAGE Wayne Roseberry Microsoft Author of Writing Test Plans Made

CODE COVERAGE ISNT COVERAGE Wayne Roseberry Microsoft Author of Writing Test Plans Made

CODE COVERAGE ISNT COVERAGE Wayne Roseberry Microsoft Author of Writing Test Plans Made Easy The Rules People respond to rewards and punishments Dont Chase The Numbers High Code Coverage &lt;&gt; Good But low coverage

388 views • 12 slides
80% of Code Red 2 Code Red 2 re-re- Code Red 1 and Code Red 2 Code Red 2 re- cleaned up

80% of Code Red 2 Code Red 2 re-re- Code Red 1 and Code Red 2 Code Red 2 re- cleaned up

Slammer s Bandwidth-Limited Growth 80% of Code Red 2 Code Red 2 re-re- Code Red 1 and Code Red 2 Code Red 2 re- cleaned up due to released Jan 2004 Nimda endemic dies off released with Oct. onset of Blaster (and 2005; not since

450 views • 34 slides
Review of Curse &amp; &amp; Abuse Code Sections Public Safety Committee Meeting Colonel

Review of Curse &amp; &amp; Abuse Code Sections Public Safety Committee Meeting Colonel

Abusive Language to Another Review of Curse &amp; &amp; Abuse Code Sections Public Safety Committee Meeting Colonel Edwin C. Roessler Jr. Chief of Police October 23, 2018 Code of Virginia and County Code Sections Code of Virginia

160 views • 5 slides
Code Modification Forum Telco/Webex, Wednesday, 19 August 2020 Agenda 1. Review of minutes from

Code Modification Forum Telco/Webex, Wednesday, 19 August 2020 Agenda 1. Review of minutes from

Code Modification Forum Telco/Webex, Wednesday, 19 August 2020 Agenda 1. Review of minutes from last meeting 2. Review of open actions 3. Post Brexit customs declarations 4. GNI Update re Impact of Covid 19 5. Update on Maintenance 6. Gas

523 views • 25 slides
Requirements for the Phase Down of Hydrofluorocarbons 7 DE Admin Code 1151 Review Committee

Requirements for the Phase Down of Hydrofluorocarbons 7 DE Admin Code 1151 Review Committee

Requirements for the Phase Down of Hydrofluorocarbons 7 DE Admin Code 1151 Review Committee Meeting DNREC DAQ October 8, 2019 Review Committee Goal To help the Department craft/tailor the regulation ( 7 DE Admin. Code 1151

187 views • 15 slides
Defense Daily Open Architecture Summit 2014 Defense Daily Open Architecture Summit 2014 PEO IWS

Defense Daily Open Architecture Summit 2014 Defense Daily Open Architecture Summit 2014 PEO IWS

Defense Daily Open Architecture Summit 2014 Defense Daily Open Architecture Summit 2014 PEO IWS Open Architecture Implementation PEO IWS Open Architecture Implementation Mr. Bill Bray, Executive Director Mr. Bill Bray, Executive Director

424 views • 16 slides
ANTI-GRAVITY HARNESS TEAM TEAM 10 Eileen Baker Hasan Farman Khaled Alosaimi Noah Oliver AJ.

ANTI-GRAVITY HARNESS TEAM TEAM 10 Eileen Baker Hasan Farman Khaled Alosaimi Noah Oliver AJ.

ANTI-GRAVITY HARNESS TEAM TEAM 10 Eileen Baker Hasan Farman Khaled Alosaimi Noah Oliver AJ. Garcia 1 Project Background Almost 1 million children in the U.S. suffer from degenerative diseases Children with limited mobility are

324 views • 13 slides
Environment Model Building Tools MSE Presentation 3 Esteban Guillen Outline Action Items

Environment Model Building Tools MSE Presentation 3 Esteban Guillen Outline Action Items

Environment Model Building Tools MSE Presentation 3 Esteban Guillen Outline Action Items Project Evaluation Assessment Evaluation Component Design XML File Description Future Work Conclusion References Demo

501 views • 33 slides
Ocean Meets Regions The Regional Aspects of Ocean Governance Pascal Derycke EMODnet Secretariat

Ocean Meets Regions The Regional Aspects of Ocean Governance Pascal Derycke EMODnet Secretariat

Ocean Meets Regions The Regional Aspects of Ocean Governance Pascal Derycke EMODnet Secretariat &amp; Jan-Bart Calewaert Janbart.Calewaert@emodnet.eu Marine Knowledge Value Chain Data can only create provide knowledge and reduce uncertainty

109 views • 9 slides
Cosmological models with nonlocal scalar fields Sergey Yu. Vernov SINP MSU based on the

Cosmological models with nonlocal scalar fields Sergey Yu. Vernov SINP MSU based on the

Cosmological models with nonlocal scalar fields Sergey Yu. Vernov SINP MSU based on the following papers I.Ya. Arefeva, L.V. Joukovskaya, S.V., J. Phys A 41 (2008) 304003, arXiv:0711.1364 S.V., Class. Quant. Grav. 27 (2010) 035006,

439 views • 30 slides
An Empirical Study of UHF RFID Performance Michael Buettner and David Wetherall Presented by

An Empirical Study of UHF RFID Performance Michael Buettner and David Wetherall Presented by

An Empirical Study of UHF RFID Performance Michael Buettner and David Wetherall Presented by Qian (Steve) He CS 577 - Prof. Bob Kinicki Overview Introduction Background Knowledge Methodology and Tools Experiment &amp; Result

570 views • 46 slides
FYP (2019-20) Presentation Schedule Version - 13 May, 2020 Page 1 of 5 * Classroom reserved for

FYP (2019-20) Presentation Schedule Version - 13 May, 2020 Page 1 of 5 * Classroom reserved for

FYP (2019-20) Presentation Schedule Version - 13 May, 2020 Page 1 of 5 * Classroom reserved for FYP group members: Since the presentation will be conducted via Zoom Meeting, most of the students may do the presentation at home with your own

174 views • 5 slides
BLACK NOVA PRODUCT ORDERING SKU TRAINING 2019 Internal use only Confidential content - All

BLACK NOVA PRODUCT ORDERING SKU TRAINING 2019 Internal use only Confidential content - All

BLACK NOVA PRODUCT ORDERING SKU TRAINING 2019 Internal use only Confidential content - All right reserved - Black Nova Ltd. - 2019 V.1.1 April 2019 AM Training Structure 1. What is a SKU 2. Order a keypad 3. SKU Structure

472 views • 29 slides

More recommend